barchstien writes
When building v1.1.1 and v1.1.0, downloaded from https://github.com/medoc92/upmpdcli/archive/ I get : src/main.cxx:115:9: error: PACKAGE_VERSION was not declared in this scope PACKAGE_VERSION, // info ^ Makefile:648: recipe for target src/main.o failed make: *\ [src/main.o] Error 1
Note that the version from current git does not have this problem I tried to look around with grep, but didn’t fins anything obvious… I added : -DPACKAGE_VERSION=\"${PACKAGE_VERSION}" to Makefile.am, but it didn’t help
If I add the following lines in main.cxx (few lines before the error is reported) everything compiles fine # define PACKAGE_VERSION "1.1.0"
If I add #include "config.h" to main.cxx compilation is ok too
Hopefully, this is some kind of easy-to-fix for someone who’s used to the code Any hints are appreciated, so that I can dig in the code with the right approach
Cheers
barchstien writes
Forgot to mention, building on Arch ARM
$g --version
g
(GCC) 5.3.0
Copyright © 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
barchstien writes
ok… just did a diff with master vs tag v1.1.1 https://github.com/medoc92/upmpdcli/compare/upmpdcli-v1.1.0…master And it seams this was already solved adding #include "config.h" in main.cxx
Never mind :-)